22:21 jca usr.sbin/dhcpd/dhcpd.conf.5 1.18
Appropriately replace "domain name" with "hostname"; less misleading
tb@ was initially concerned about next-server but there were more similar occurrences. Simple solution - "hostname" - proposed by jmc@ ok from both
10:49 mestre usr.sbin/dhcpd/dispatch.c 1.38
usr.sbin/dhcpd/icmp.c 1.15
usr.sbin/dhcpd/options.c 1.33
usr.sbin/dhcpd/pfutils.c 1.15
Replace bzero(3) with memset(3)
"Looks good" to deraadt@
21:05 krw usr.sbin/dhcpd/dhcp.c 1.52
Compare server-identifiers and reject packets only *after* applying value specified in dhcpd.conf.
i.e. don't assume it is always the primary address of the interface the packet arrived on.
Fixes issues with redundant dhcpd servers and CARP'd interfaces.
Issue reported and fix tested by Johan Huldtgren
11:34 mestre usr.sbin/dhcpd/sync.c 1.19
- Use memset(*b, 0, len) instead of bzero(*b, len) - Use explicit_bzero(3) instead of bzero(3) to clean temporary HMAC
OK krw@
13:36 krw usr.sbin/dhcpd/dhcp.c 1.51
client_identifier is not a string so using strlen() on it is inappropriate. Which is why client_identifier_len exists.
Replace copy&pasted strlen() with client_identifier_len.
Symptoms (crash) and cause (bad c&p) spotted by sthen@.
tested & ok sthen@
15:53 krw usr.sbin/dhcpd/dhcp.c 1.50
Stop pretending we use RFC 3046/Option 82/Relay Agent Information.
RFC 3042 says servers that do not understand the option will not echo it.
Plus, our desultory attempt at echoing was almost certainly broken for OFFERs (use after free of packet data) and not even attempted for NACKs.
ok millert@
16:12 krw usr.sbin/dhcpd/dhcp.c 1.49
usr.sbin/dhcpd/dhcpd.h 1.55
Add support for RFC 6842. RFC 2131 said the server MUST NOT echo the client-identifier value. RFC 6842 says the server MUST echo it.
Echoing the information disambiguates packets for relays and clients when chaddr is 0. Similar to what dhcpv6 does.
00:50 krw usr.sbin/dhcpd/dhcp.c 1.48
Use consistant idiom (intermediate variable 'i' rather than repeated uses of very long #define names) to access option data in nak_lease() and ack_lease().
Shortens a lot of lines, which allows a number of line splits to be eliminates.
Makes some upcoming diffs easier to integrate.
No intentional functional change.
22:47 krw usr.sbin/dhcpd/dhcp.c 1.47
usr.sbin/dhcpd/options.c 1.32
usr.sbin/dhcpd/sync.c 1.18
usr.sbin/dhcpd/sync.h 1.5
Zap stray whitespace.
01:26 guenther usr.sbin/dhcpd/db.c 1.16
usr.sbin/dhcpd/dhcpd.c 1.52
usr.sbin/dhcpd/dispatch.c 1.37
usr.sbin/dhcpd/parse.c 1.21
Pull in <time.h> for one or more of gmtime, strftime, strptime, time, timegm, and tzset
ok deraadt@
00:55 krw usr.sbin/dhcpd/confpars.c 1.28
KNF and clean up many comments.
00:38 krw usr.sbin/dhcpd/confpars.c 1.27
Ansify function definitions.
Diff from Edgar Pettijohn.
14:02 krw usr.sbin/dhcpd/dhcp.c 1.46
usr.sbin/dhcpd/dhcpd.h 1.54
usr.sbin/dhcpd/options.c 1.31
Don't leak the option data of non-DHCPINFORM messages received on the udp socket.
Found by David Carlier.
ok yasuoka@
07:00 tag OPENBSD_6_0_BASE added
07:00 natano usr.sbin/dhcpd/bpf.c 1.14
Replace the /dev/bpf* open loop with a plain open("/dev/bpf0", ...). ok deraadt jca
10:16 mestre usr.sbin/dhcpd/dhcpd.c 1.51
usr.sbin/dhcpd/udpsock.c 1.7
Remove pledge(2)'s that are called before chroot(2) since in the near future this will be forbidden. The remaining pledge(2) calls after chroot(2) are still kept.
OK semarie@ "it is time now"
14:00 mestre usr.sbin/dhcpd/udpsock.c 1.6
In udpsockmode codepath dhcpd.c had the promise route for pledge(2) but it was missing from udpsock_startup() (udpsock.c) which happens earlier and therefore would abort the program due to SIOCGIFADDR ioctl(2) on udpsock_handler
Reported by Philip Higgins <phil ! unita.com.au>
OK tb@
02:06 tag OPENBSD_5_9_BASE added
02:06 krw usr.sbin/dhcpd/udpsock.c 1.5
sys/param.h -> sys/types.h. No need to drag in nitems() only to use it once on an array declared iov[1]. Just use '1'.
ok yasuoka@
10:24 jsg usr.sbin/dhcpd/memory.c 1.25
avoid a use after free when parsing address ranges from a config ok krw@
23:50 krw usr.sbin/dhcpd/alloc.c 1.14
usr.sbin/dhcpd/bootp.c 1.16
usr.sbin/dhcpd/bpf.c 1.13
usr.sbin/dhcpd/conflex.c 1.16
usr.sbin/dhcpd/confpars.c 1.26
usr.sbin/dhcpd/convert.c 1.5
usr.sbin/dhcpd/db.c 1.15
usr.sbin/dhcpd/dhcp.c 1.45
usr.sbin/dhcpd/dhcpd.c 1.50
usr.sbin/dhcpd/dhcpd.h 1.53
usr.sbin/dhcpd/dispatch.c 1.36
usr.sbin/dhcpd/errwarn.c 1.9
usr.sbin/dhcpd/hash.c 1.7
usr.sbin/dhcpd/icmp.c 1.14
usr.sbin/dhcpd/inet.c 1.6
usr.sbin/dhcpd/memory.c 1.24
usr.sbin/dhcpd/options.c 1.30
usr.sbin/dhcpd/packet.c 1.11
usr.sbin/dhcpd/parse.c 1.20
usr.sbin/dhcpd/pfutils.c 1.14
usr.sbin/dhcpd/print.c 1.11
usr.sbin/dhcpd/sync.c 1.17
usr.sbin/dhcpd/tables.c 1.12
usr.sbin/dhcpd/tree.c 1.17
usr.sbin/dhcpd/udpsock.c 1.4
Eliminate #include inside *.h files and include only needed headers in each *.c file.
Inspired by mention of header silliness by Edgar Pettijohn and mmcc@ on tech@.
14:48 krw usr.sbin/dhcpd/packet.c 1.10
be very careful accepting packets via bpf. First check that the fixed part of the IP header is completely present before using its header length field. Then use the data in the IP header to ensure the entire IP packet is present. Then check that the entire UDP header is present. Then use the data in the UDP header to ensure all the data it thinks is present is actually present.
Started when tj@ and a few others noticed ISC "DHCP CVE-2015-8605: UDP payload length not properly checked".
ok sthen@ henning@
21:39 mmcc usr.sbin/dhcpd/alloc.c 1.13
usr.sbin/dhcpd/dhcp.c 1.44
usr.sbin/dhcpd/tree.c 1.16
remove NULL-checks before free()
01:08 krw usr.sbin/dhcpd/dhcpd.c 1.49
usr.sbin/dhcpd/udpsock.c 1.3
Diff from Ricardo Mestre. Test report from sthen@.
14:09 krw usr.sbin/dhcpd/parse.c 1.19
Actually use default-lease-time, max-lease-time, bootp-lease-length specified in dhcpd.conf. Broken in -r1.18.
Problem noted by Arne on bugs@, identical fix independently developed by Serguey Parkhomovsky.
20:06 schwarze usr.sbin/dhcpd/dhcp-options.5 1.22
Avoid .Ns right after .Pf, it's pointless. In some cases, do additional cleanup in the immediate vicinity.
22:39 deraadt usr.sbin/dhcpd/confpars.c 1.25
usr.sbin/dhcpd/dhcp.c 1.43
usr.sbin/dhcpd/dispatch.c 1.35
stdlib.h is in scope; do not cast malloc/calloc/realloc* ok millert krw
18:48 tag OPENBSD_5_8_BASE added
18:48 sobrado usr.sbin/dhcpd/dhcpd.leases.5 1.13
use file system path (.Pa) semantic markup macros where appropriate.
14:29 krw usr.sbin/dhcpd/options.c 1.29
usr.sbin/dhcpd/tables.c 1.11
Do not send routers (option 3) or static routes (option 33) when classless static routes (option 121, 249) are sent. RFC 3442 says servers SHOULD NOT send those options.
This avoids confusing clients who fail to ignore the routers or static routes options in the presence of classless static routes options. RFC 3442 says clients MUST ignore those options.
Incorrect behavior in MS and Linux clients reported by Juan on misc@.
ok millert@
12:48 schwarze usr.sbin/dhcpd/dhcpd.conf.5 1.17
Don't do manual whitespace adjustments inside semantic macros, rather do it before the macros, and get rid of cargo cult escaping. Both to make the code more robust and less ugly, no output change. Ugly code reported by TJ at mrsk dot me. OK jmc@
16:02 sobrado usr.sbin/dhcpd/dhcp-options.5 1.21
write Mobile IP{,v6} in a consistent way, as given in RFCs 5944 and 6275.
ok jmc@
17:51 krw usr.sbin/dhcpd/conflex.c 1.15
usr.sbin/dhcpd/confpars.c 1.24
usr.sbin/dhcpd/parse.c 1.18
Tweak parsing so that hostnames starting with 0-9 are accepted.
Reported long ago by matthieu@. Also Jacob Berkman via the lists.
Tests and suggestions from Jacob and Matthieu.
14:29 krw usr.sbin/dhcpd/conflex.c 1.14
Hoist common assignments out of a series of if/if-else statements in get_token(). Simplifies code and shrinks future diff.
No intentional functional change.
12:37 krw usr.sbin/dhcpd/conflex.c 1.13
Correct switch between current and previous line buffers when encountering a carriage return in the input.
Found by jsg@ a long time ago in a respository far, far away.
12:40 krw usr.sbin/dhcpd/dhcp.c 1.42
Avoid using inet_ntoa() twice in a single printf() parameter list by caching the results from excess inet_ntoa() calls before doing the printf(). Should improve usefullness (?) of DHCPRELEASE log entries by actually printing ciaddr and giaddr correctly when dhcprelays stand between servers and clients.
Looks good to dlg@.
19:58 jmc usr.sbin/dhcpd/dhcpd.8 1.27
usr.sbin/dhcpd/dhcpd.conf.5 1.16
remove the first comma from constructs like ", and," and ", or,": you can use "and" and "or" to join sentence clauses, and you can use commas, but both hinders reading;
23:06 tag OPENBSD_5_7_BASE added
23:06 krw usr.sbin/dhcpd/dhcpd.c 1.48
usr.sbin/dhcpd/memory.c 1.23
Keep track of the last time we scanned the leases to find expired ones that needed to be booted out of the pf table process. This avoids removing the same addess over and over.
Problem report and original diff from Bertrand Provost.
10:49 krw usr.sbin/dhcpd/dhcpd.c 1.47
Close appropriate ends of pfpipe. Lets pf table process die when dhcpd does.
Pointed out by Bertrand Provost.
ok henning@
09:42 krw usr.sbin/dhcpd/pfutils.c 1.13
The pf table process should die if the pipe to the dhcpd process is closed. e.g. dhcpd has been killed.
ok henning@
21:50 deraadt usr.sbin/dhcpd/pfutils.c 1.12
Include <netinet/in.h> before <net/pfvar.h>. In a future change when ports is ready, <net/pfvar.h> will stop including a pile of balony.
06:40 deraadt usr.sbin/dhcpd/dhcpd.c 1.46
usr.sbin/dhcpd/pfutils.c 1.11
usr.sbin/dhcpd/sync.c 1.16
usr.sbin/dhcpd/udpsock.c 1.2
Replace <sys/param.h> with <limits.h> and other less dirty headers where possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
18:15 deraadt usr.sbin/dhcpd/dhcpd.8 1.26
/dev/random has created the same effect as /dev/arandom (and /dev/urandom) for quite some time. Mop up the last few, by using /dev/random where we actually want it, or not even mentioning arandom where it is irrelevant.
14:41 bentley usr.sbin/dhcpd/dhcpd.leases.5 1.12
Reduce instances of `` '' in manuals.
troff displays these as typographic quotes, but nroff implementations almost always print them literally, which rarely has the intended effect with modern fonts, even in stock xterm.
These uses of `` '' can be replaced either with more semantic alternatives or with Dq, which prints typographic quotes in a UTF-8 locale (but will automatically fall back to `` '' in an ASCII locale).
improvements and ok schwarze@
19:59 krw usr.sbin/dhcpd/dhcp.c 1.41
Tweak the the DHCPACK to DHCPINFORM log entry so that it is less threatening and more informative.
DHCPACK on <null address> to 5c:51:4f:56:81:c3 via em0
changes to
DHCPACK to (3c:97:0e:0c:0c:d7) via em0
Issue noted and diff tested by Marc Peters. Thanks!
ok yasuoka@ millert@
13:03 krw usr.sbin/dhcpd/dhcp.c 1.40
Typo: consitent -> consistent.
03:23 lteo usr.sbin/dhcpd/bpf.c 1.12
usr.sbin/dhcpd/icmp.c 1.13
usr.sbin/dhcpd/packet.c 1.9
Remove unnecessary netinet/in_systm.h include.
ok millert@
04:26 deraadt usr.sbin/dhcpd/dispatch.c 1.34
use reallocarray() to cope with multiplicative integer overflow; ok doug
20:58 tobias usr.sbin/dhcpd/packet.c 1.8
Variables to count seen packets should be unsigned.
ok krw@
18:39 tobias usr.sbin/dhcpd/dhcp.c 1.39
validate len field for proper length, not just "not zero."
ok krw@
18:21 tobias usr.sbin/dhcpd/options.c
Fix memory exhaustion occurring on DHCP options with 0 length.
halex@ and krw@ pointed out that a NULL check before free can go, too.
ok deraadt@, halex@, krw@, jasper@
16:45 tag OPENBSD_5_6_BASE added
16:45 tobias usr.sbin/dhcpd/options.c 1.28
Fix memory exhaustion occurring on DHCP options with 0 length.
halex@ and krw@ pointed out that a NULL check before free can go, too.
ok deraadt@, halex@, krw@
07:48 tobias usr.sbin/dhcpd/packet.c 1.7
Fix very hard to reach DoS attack vector, which would involve more than 8 billion network packets. Mixture of many many malformed and proper packets could result in a division by zero.
ok krw@
16:48 yasuoka usr.sbin/dhcpd/dhcp.c 1.38
usr.sbin/dhcpd/dhcpd.h 1.52
Fix DHCPINFORM not to lookup the lease database, not to fill the yiaddr field and not to include the lease time parameters.
ok krw
13:53 jmc usr.sbin/dhcpd/dhcpd.8 1.25
tweak previous; ok krw yasuoka
09:44 yasuoka usr.sbin/dhcpd/dhcpd.8 1.24
Fix typo
09:42 yasuoka usr.sbin/dhcpd/Makefile 1.5
usr.sbin/dhcpd/bootp.c 1.15
usr.sbin/dhcpd/bpf.c 1.11
usr.sbin/dhcpd/dhcp.c 1.37
usr.sbin/dhcpd/dhcpd.8 1.23
usr.sbin/dhcpd/dhcpd.c 1.45
usr.sbin/dhcpd/dhcpd.h 1.51
usr.sbin/dhcpd/options.c 1.27
usr.sbin/dhcpd/udpsock.c 1.1
Add -u option to bind UDP port as a socket to answer DHCPINFORM from the clients on non ethernet interfaces (eg. tun(4) or pppx(4)).
input krw ok krw
13:42 yasuoka usr.sbin/dhcpd/confpars.c 1.23
Fix classless-{ms-,}static-routes to comply RFC 3442. Number of octets should be changed by corresponding to the prefix length. And 0 should be allowed for the prefix length. Also fix white spaces.
Based on diff from Yuuichi Someya.
ok krw
16:45 pelikan usr.sbin/dhcpd/bootp.c 1.14
usr.sbin/dhcpd/memory.c 1.22
Prettify & refactor, no functional change.
ok beck
13:20 pelikan usr.sbin/dhcpd/dhcpd.c 1.44
usr.sbin/dhcpd/dhcpd.h 1.50
usr.sbin/dhcpd/icmp.c 1.12
back out the previous ICMP simplifying diff, it caused livelocks.
reported by Mikolaj Kucharski, thanks! ok krw
18:30 pelikan usr.sbin/dhcpd/dhcpd.c 1.43
usr.sbin/dhcpd/dhcpd.h 1.49
usr.sbin/dhcpd/dispatch.c 1.33
Don't call the BOOTP handler indirectly.
ok krw
18:27 pelikan usr.sbin/dhcpd/dhcpd.c 1.42
usr.sbin/dhcpd/dhcpd.h 1.48
usr.sbin/dhcpd/icmp.c 1.11
Don't call the ICMP handler indirectly + clean up a bit.
ok krw
18:12 tag OPENBSD_5_5_BASE added
18:12 krw usr.sbin/dhcpd/db.c 1.14
Create dhclient lease files and dhcpd lease files with permissions 0640, rather than 0000 and 0664 respectively.
ok kettenis@ tedu@
07:52 jmc usr.sbin/dhcpd/dhcp-options.5 1.20
03:07 krw usr.sbin/dhcpd/confpars.c 1.22
usr.sbin/dhcpd/dhcp-options.5 1.19
usr.sbin/dhcpd/dhcp.h 1.10
usr.sbin/dhcpd/tables.c 1.10
Add parsing for options 121 (classless-static-routes) and 249 (classless-ms-static-routes). dhcpd can now specify and serve these options and dhclient can recognize and use supersede, etc. statements on them.
Based on a diff from Stefan Rinke. Thanks!
16:21 jmc usr.sbin/dhcpd/dhcp-options.5 1.18
usr.sbin/dhcpd/dhcpd.8 1.22
usr.sbin/dhcpd/dhcpd.conf.5 1.15
usr.sbin/dhcpd/dhcpd.leases.5 1.11
consistent Nd lines for the various dhcp bits; help/ok krw
20:37 krw usr.sbin/dhcpd/parse.c 1.17
Two 'break;'s in a row seems excessive.
22:31 krw usr.sbin/dhcpd/conflex.c 1.12
usr.sbin/dhcpd/dhcp.h 1.9
usr.sbin/dhcpd/dhctoken.h 1.7
usr.sbin/dhcpd/parse.c 1.16
Stop pretending we still support FDDI or token ring hardware types.
idea ok deraadt@ matthew@
21:03 krw usr.sbin/dhcpd/packet.c 1.6
Nuke local #define ETHER_HEADER_SIZE and use the identical value'd ETHER_HDR_LEN from if_ether.h. dhclient change ok matthew@ as part of larger diff.
04:47 deraadt usr.sbin/dhcpd/parse.c 1.15
unsigned char cast for some ctype calls ok krw
12:02 krw usr.sbin/dhcpd/confpars.c 1.21
Use the provided netmask on the subnet value provided in 'subnet' statements, allowing subsequent comparisions with interface addresses to always work properly.
Problem noted, fix tested & ok dlg@
18:15 schwarze usr.sbin/dhcpd/dhcpd.conf.5 1.14
usr.sbin/dhcpd/dhcpd.leases.5 1.10
fix a few obvious .Ar markup errors (unfortunately, there are many more) found while working on mandoc apropos
15:19 krw usr.sbin/dhcpd/dispatch.c 1.32
usr.sbin/dhcpd/pfutils.c 1.10
usr.sbin/dhcpd/sync.c 1.15
Scattering a few bcopy()'s around source using mostly memcpy() is just asking for confusion. Replace bcopy()'s with memcpy()'s.
13:44 krw usr.sbin/dhcpd/memory.c 1.21
usr.sbin/dhcpd/sync.c 1.14
%d -> %lld, add (long long) cast to time_t variables. Make guenther and gcc happier. Found while looking at something else for dlg@.
11:13 tag OPENBSD_5_4_BASE added
11:13 schwarze usr.sbin/dhcpd/dhcp-options.5 1.17
usr.sbin/dhcpd/dhcpd.8 1.21
usr.sbin/dhcpd/dhcpd.conf.5 1.13
usr.sbin/dhcpd/dhcpd.leases.5 1.9
use .Mt for email addresses; from Jan Stary <hans at stare dot cz>; ok jmc@
10:26 jmc usr.sbin/dhcpd/dhcpd.conf.5 1.12
usr.sbin/dhcpd/dhcpd.leases.5 1.8
simplify some icky macros; from Jan Stary, tweaked by me
07:56 jmc usr.sbin/dhcpd/dhcp-options.5 1.16
remove non-standard section: it does nothing for this page;
19:44 jmc usr.sbin/dhcpd/dhcpd.8 1.20
merge the relevant bits of dhcp(8) into dhclient(8) and dhcpd(8), removing traces of dhcp(8)... i'm about to remove that file, since it's essentially useless. holding off for a little, in case my commit is greeted with howls.
help/ok krw
15:15 jmc usr.sbin/dhcpd/dhcp-options.5 1.15
usr.sbin/dhcpd/dhcpd.8 1.19
update (or add) STANDARDS; help/ok krw
13:00 krw usr.sbin/dhcpd/conflex.c 1.11
Fix "\" escape handling in read_string().
Problem noted, fix tested and ok sthen@.
19:24 gerhard usr.sbin/dhcpd/dispatch.c 1.31
poll(2) might have slept for an arbitrary amount of time. We should update 'cur_time' after poll(2) returns.
ok otto
15:02 krw usr.sbin/dhcpd/sync.c 1.13
When sync'ing, look for lease by hwaddr and then ipaddr. Not hwaddr twice. Simplify logic. Fixes loops while sync'ing for sthen@.
Spotted by & fixed tested by sthen@.
01:18 krw usr.sbin/dhcpd/db.c 1.13
Remove extraneous "\n" erroneously introduced by move to strftime().
Spotted by sthen@.
21:25 sthen usr.sbin/dhcpd/dispatch.c 1.30
Log (at LOG_INFO) which interfaces dhcpd listens to and (as suggested by krw) their address. As dhcpd uses BPF, it's not possible to find this information out from fstat/netstat. ok krw@
19:26 krw usr.sbin/dhcpd/db.c 1.12
usr.sbin/dhcpd/dhcpd.h 1.47
usr.sbin/dhcpd/parse.c 1.14
Replace hand-rolled date printing/parsing code with strftime()/strptime(). Use timegm() because all the dates are in UTC and the 'standard' routines can't handle the truth.
Remove some 'time_t is 32bits' assumptions.
Print 'UTC' at the end of dates in the leases file, rather than mentioning that all dates are UTC in a comment at the top of the file.
Feedback and suggestions from guenther@, kettenis@, otto@, tedu@, deraadt@.
18:08 krw usr.sbin/dhcpd/sync.c 1.12
usr.sbin/dhcpd/sync.h 1.4
Give struct dhcp_synctlv_lease fields a prefix (lv_) as the fields in other structs have. Reduces potential for confusion with fields of same name but different types in leases. Use consistent variable name. No change to executable.
16:40 krw usr.sbin/dhcpd/db.c 1.11
Don't dance with errno, just check the return values of fprintf(), fputs() and fputc() to see if a failure occurred. Add a couple of missing checks. Replace putc() with fputc(). Shorter, nicer code. No functional change.
ok fgsch@
00:27 krw usr.sbin/dhcpd/sync.c 1.11
Unbreak lease synchronization by making the sync header contain the correct packet length even when paddding is present. Previously the HMAC calculated by the receiver would not be based on the whole packet.
Problem noted and essentially identical diffs from Kapetanakis Giannis via misc@ and then Johan Ymerson via bugs@.
19:31 krw usr.sbin/dhcpd/bpf.c 1.10
usr.sbin/dhcpd/dhcp.c 1.36
send_packet() and writev() return ssize_t, not int. Use correct type to store the returned value. From dhill.
23:45 krw usr.sbin/dhcpd/dhcp.c 1.35
RFC 2131 4.3.1 seems clear that a server MUST NOT include the client-identifier option in OFFER or ACK messages. So stop doing so.
15:43 krw usr.sbin/dhcpd/dhcp.c 1.34
RFC 2131 says don't ACK any REQUEST messages that contain a server-identifier option that specifies a different dhcp server.
So don't.
Pointed put and fix tested by Andy via bugs@
22:06 tag OPENBSD_5_3_BASE added
22:06 krw usr.sbin/dhcpd/dhcp.c 1.33
Obey RFC 2131 and when the broadcast flag is set send reply back via udp broadcast and link-local broadcast. Not udp broadcast to link address of client. Fixes at least some switches who use the broadcast flag.
Bug submitted by Andy via bugs@, and fix tested by same. Thanks!
ok beck@
21:04 krw usr.sbin/dhcpd/bpf.c 1.9
usr.sbin/dhcpd/dhcpd.h 1.46
usr.sbin/dhcpd/packet.c 1.5
Remove unused (a.k.a. always passed NULL) parameter 'data' from decode_udp_ip_header() and the useless check of it. Part of original diff from pelikan about udp length errors.
18:38 krw usr.sbin/dhcpd/dhcp.h 1.8
Tweak whitespace, add missing #defines, use DHO_RELAY_AGENT_INFORMATION rather than DHO_DHCP_AGENT_OPTIONS. Makes these files identical again.
18:24 krw usr.sbin/dhcpd/dhcp.h 1.7
Add DHO_ defines for all known options. Use same names as ISC where available. No functional change.
12:34 krw usr.sbin/dhcpd/packet.c 1.4
Check UDP length field for short as well as long values. Fixes a dhcpd crash when a UDP packet arrives saying it has 0 length.
Spotted by Martin Pelikan, who also noted it was fixed a while ago in ISC DHCP 3.0b2p17.
Fix tested by Martin. Thanks!
16:35 krw usr.sbin/dhcpd/dhcp-options.5 1.14
Don't mention the (incorrect) option number of autoproxy-script, since we don't mention the option numbers for other options.
Noticed by Marcus Merighi vi tech@.
16:41 krw usr.sbin/dhcpd/dhcp-options.5 1.13
Rework to simply list all options in alphabetical order. Functional groupings and sub-ordering them in RFC/numerical order did not make for a readable man page.
Add a number of missing option descriptions. Started by man page update from Marcus Merighi via tech@. Thanks!
Further fixes and tweaks by jmc@. ok jmc@.
16:19 jmc usr.sbin/dhcpd/dhcp-options.5 1.12
usr.sbin/dhcpd/dhcpd.conf.5 1.11
usr.sbin/dhcpd/dhcpd.leases.5 1.7
last stage of rfc changes, using consistent Rs/Re blocks, and moving the references into a STANDARDS section;
18:13 jmc usr.sbin/dhcpd/dhcp-options.5 1.11
update the rfc references; ok krw
15:39 tag OPENBSD_5_1_BASE added
15:39 tag OPENBSD_5_2_BASE added
15:39 krw usr.sbin/dhcpd/dispatch.c 1.29
Zero option processing stack storage to prevent stack garbage that happens to look like options from being processed as options when truncated packets received.
Potential problem pointed out by mikeb@, from a couple of NIST reports (CVE-2011-2748 and CVE-2011-2749).
17:38 tag OPENBSD_4_9_BASE added
17:38 tag OPENBSD_5_0_BASE added
17:38 claudio usr.sbin/dhcpd/sync.c 1.10
Use the provided note() and warning() functions of dhcpd instead of calling syslog_r() directly -- this make -d work as expected. OK reyk@, stsp@, deraadt@
14:34 claudio usr.sbin/dhcpd/dhcpd.c 1.41
We run getopt() twice to know if dhcp-sync is used. To make this work both getopt calls need the same optstring or the first getopt() call will end before parsing all arguments. Problem found and fixed supplied by m_athias OK millert@, deraadt@
08:00 ajacoutot usr.sbin/dhcpd/dispatch.c 1.28
Prevent dhcpd(8) from trying to listen on interfaces that don't have a valid broadcast (e.g. pflog0).
"no objection" krw@, ok claudio@
15:43 sobrado usr.sbin/dhcpd/dhcpd.8 1.18
use the right capitalization in the Nd strings.
ok jmc@
04:44 tag OPENBSD_4_8_BASE added
04:44 guenther usr.sbin/dhcpd/dhcpd.c 1.40
usr.sbin/dhcpd/dispatch.c 1.27
Fix the naming of interfaces and variables for rdomains and rtables and make it possible to bind sockets (including listening sockets!) to rtables and not just rdomains. This changes the name of the system calls, socket option, and ioctl. After building with this you should remove the files /usr/share/man/cat2/[gs]etrdomain.0.
Since this removes the existing [gs]etrdomain() system calls, the libc major is bumped.
Written by claudio@, criticized^Wcritiqued by me
12:22 claudio usr.sbin/dhcpd/dhcpd.c 1.39
usr.sbin/dhcpd/dhcpd.h 1.45
usr.sbin/dhcpd/dispatch.c 1.26
If interfaces are specified, get their rdomain and bind dhcpd into the same domain with setrdomain(). This allows to run dhcpd on multiple rdomains. OK krw@
17:03 zinovik usr.sbin/dhcpd/confpars.c 1.20
plug memory leaks on error paths
joint work with krw@
ok krw@, stsp@
22:22 krw usr.sbin/dhcpd/dhcp.c 1.32
Initialize 'flags' field of tree_cache stack variables to 0. Paranoia.
22:09 krw usr.sbin/dhcpd/dhcp.c 1.31
Always put server id in NAK's to requests. Some router/switches need this, as reported in PR#6339.
Fix tested by submitter, Marcel Widget, who also supplied the diff that I tweaked.
ok beck@
14:11 krw usr.sbin/dhcpd/confpars.c 1.19
usr.sbin/dhcpd/memory.c 1.20
usr.sbin/dhcpd/parse.c 1.13
usr.sbin/dhcpd/sync.c 1.9
malloc/strlcpy -> strdup. Use consistent idiom.
ok (as part of larger diff) blambert@ kettenis@ stsp@ zinovik@
18:37 tag OPENBSD_4_7_BASE added
18:37 deraadt usr.sbin/dhcpd/sync.c 1.8
unused prototype
04:21 krw usr.sbin/dhcpd/alloc.c 1.12
usr.sbin/dhcpd/confpars.c 1.18
usr.sbin/dhcpd/dhcp.c 1.30
usr.sbin/dhcpd/dhcpd.h 1.44
usr.sbin/dhcpd/dispatch.c 1.25
usr.sbin/dhcpd/options.c 1.26
usr.sbin/dhcpd/tree.c 1.15
Eliminate all uses of dmalloc() where the returned pointer is checked for NULL and a specific error/warning issued. Add two such manual warning/error checks and kill those dmalloc calls. And then there were none, so kill dmalloc(). Whew.
20:46 krw usr.sbin/dhcpd/alloc.c 1.11
usr.sbin/dhcpd/dhcp.c 1.29
usr.sbin/dhcpd/options.c 1.25
usr.sbin/dhcpd/tree.c 1.14
Eliminate all uses of dfree() where the pointer is either dereferenced immediately before the use or the pointer is checked for NULL before the call. And then there were none, so kill dfree().
20:30 krw usr.sbin/dhcpd/alloc.c 1.10
usr.sbin/dhcpd/dhcpd.h 1.43
usr.sbin/dhcpd/hash.c 1.6
usr.sbin/dhcpd/memory.c 1.19
usr.sbin/dhcpd/tree.c 1.13
Wrappers around a wrapper around free() are of no more use than wrappers around wrappers around calloc().
The purpose of the free() wrapper is to generate an error message when free'ing NULL. But free_hash_bucket(), free_lease(), and free_tree() are all called immediately after dereferencing the pointer to be freed. Thus the error message will never be issued.
19:10 krw usr.sbin/dhcpd/alloc.c 1.9
usr.sbin/dhcpd/dhcpd.h 1.42
usr.sbin/dhcpd/hash.c 1.5
A slightly more complex calloc() wrapper wrapper, new_hash_table(), bites the dust.
18:01 krw usr.sbin/dhcpd/alloc.c 1.8
usr.sbin/dhcpd/dhcpd.h 1.41
usr.sbin/dhcpd/tree.c 1.12
Another calloc() wrapper wrapper, new_tree(), bites the dust.
08:02 krw usr.sbin/dhcpd/alloc.c 1.7
usr.sbin/dhcpd/confpars.c 1.17
usr.sbin/dhcpd/dhcpd.h 1.40
Two more calloc() wrapper wrappers, new_shared_network() and new_subnet(), bite the dust.
06:25 krw usr.sbin/dhcpd/alloc.c 1.6
usr.sbin/dhcpd/dhcpd.h 1.39
usr.sbin/dhcpd/hash.c 1.4
usr.sbin/dhcpd/memory.c 1.18
Single-use wrapper functions that just call a wrapper function around calloc() and end up producing duplicate error messages are just confusing.
Eliminate new_hash_bucket(), new_lease(), new_leases(), new_group().
02:38 krw usr.sbin/dhcpd/dhcpd.h 1.38
Delete unused declarations.
01:47 krw usr.sbin/dhcpd/alloc.c 1.5
usr.sbin/dhcpd/dhcpd.h 1.37
usr.sbin/dhcpd/memory.c 1.17
Plug a potential leak similar to the one parfait spotted and Theo fixed.
Eliminate the function new_class() by expanding the only use
Use strdup() and calloc() rather than manually simulating them.
No functional change.
22:12 mpf usr.sbin/dhcpd/bpf.c 1.8
Just like dhclient(8), we use the bpf filter drop to prevent us from sending an icmp error along with the dhcp reply. OK henning@
01:22 deraadt usr.sbin/dhcpd/memory.c 1.16
plug memory leak, spotted by parfait; ok krw
10:24 schwarze usr.sbin/dhcpd/dhcpd.8 1.17
fix typo; ok jmc@ also reported upstream to dhcp dash bugs at isc dot org
08:42 reyk usr.sbin/dhcpd/conflex.c 1.10
usr.sbin/dhcpd/dhcp.c 1.28
usr.sbin/dhcpd/dhcp.h 1.6
usr.sbin/dhcpd/dhcpd.conf.5 1.10
usr.sbin/dhcpd/dhctoken.h 1.6
usr.sbin/dhcpd/parse.c 1.12
usr.sbin/dhcpd/tables.c 1.9
Echo back the Relay Agent Information option if present (RFC 3046). Also add support for the "ipsec-tunnel" hardware type as described in RFC 3456.
ok henning@ krw@ (but needs more testing from others)
03:00 fgsch usr.sbin/dhcpd/dhcpd.conf.5 1.9
subnet-number and netmask could be ip addresses only. krw@ jmc@ ok
10:48 tag OPENBSD_4_5_BASE added
10:48 tag OPENBSD_4_6_BASE added
10:48 sobrado usr.sbin/dhcpd/dhcpd.conf.5 1.8
"Ethernet" is a family of networking technologies developed at Xerox PARC, not a generic name. we must use the right capitalization for this term.
ok jmc@
21:11 sthen usr.sbin/dhcpd/dhcp-options.5 1.10
usr.sbin/dhcpd/tables.c 1.8
add option 150, voip-configuration-server, as an array of IP addresses; draft-raj-dhc-tftp-addr-option-05, req by Michael van der Westhuizen.
ok henning, krw, dlg
06:04 brad usr.sbin/dhcpd/options.c
rev 1.24 Sigh. Some clients can't handle three DHO_PAD options holding space for an unused overload option. Noticed by mk@ when netbooting his G4 mac mini.
So compact the options by shifting them over the unused option and filling the end by DHO_PAD.
rev 1.23 Some clients don't parse a DHO_DHCP_OPTION_OVERLOAD option the way I expected. They object if there are no bits set in the option value. So just use DHO_PAD in the reserved space unless at least one of the bits is set.
rev 1.22 bzero' the option buffer with the correct buffer size. this fixes incomplete buffer initialization and possible incorrect option handling.
02:00 krw usr.sbin/dhcpd/options.c 1.24
Sigh. Some clients can't handle three DHO_PAD options holding space for an unused overload option. Noticed by mk@ when netbooting his G4 mac mini.
So compact the options by shifting them over the unused option and filling the end by DHO_PAD.
Tested by mk@.
01:42 krw usr.sbin/dhcpd/options.c 1.23
Some clients don't parse a DHO_DHCP_OPTION_OVERLOAD option the way I expected. They object if there are no bits set in the option value. So just use DHO_PAD in the reserved space unless at least one of the bits is set.
Various versions tested by Tobias Ulmer on OpenSolaris, matthieu@ on busybox's DHCP client, and Uwe Dippel on Solaris. All of which failed before.
20:38 claudio usr.sbin/dhcpd/bpf.c 1.7
usr.sbin/dhcpd/dispatch.c 1.24
usr.sbin/dhcpd/icmp.c 1.10
usr.sbin/dhcpd/sync.c 1.7
When checking if a syscall like open(), ioctl() or writev() failed compare directly against -1 and do not use a < 0 test. OK henning@
00:22 reyk usr.sbin/dhcpd/options.c 1.22
bzero' the option buffer with the correct buffer size. this fixes incomplete buffer initialization and possible incorrect option handling.
Thanks to Nick Bender ok krw@ deraadt@
16:51 tag OPENBSD_4_4_BASE added
16:51 millert usr.sbin/dhcpd/dhcp.c 1.27
Initial stab at DHCPINFORM support. OK phessler@
05:58 deraadt usr.sbin/dhcpd/sync.c 1.6
correct size of iov[]; ralf.horstmann@gmx.de
19:02 deraadt usr.sbin/dhcpd/dhcpd.c 1.38
appease stupid stupid gcc; ok millert
22:36 millert usr.sbin/dhcpd/dhcpd.c 1.37
Don't error out if dhcpd-sync does not exist in /etc/services and no sync options were specified. OK deraadt@
08:50 beck usr.sbin/dhcpd/sync.c 1.5
fix sync.c to not puke if sync_lease called without sync_init. from henric.
14:15 deraadt usr.sbin/dhcpd/sync.c 1.4
usr.sbin/dhcpd/sync.h 1.3
Insert pad blocks after sub-messages to keep the structures aligned to 16 byte boundaries for maximum portability (somewhat similar to CMSG's) ok beck
07:28 beck usr.sbin/dhcpd/dhcpd.c 1.36
usr.sbin/dhcpd/sync.c 1.3
this should really only be in one file.
05:38 beck usr.sbin/dhcpd/sync.c 1.2
usr.sbin/dhcpd/sync.h 1.2
don't break dhcpd when not using synch mechanisms..
12:19 beck usr.sbin/dhcpd/Makefile 1.4
usr.sbin/dhcpd/dhcp.c 1.26
usr.sbin/dhcpd/dhcpd.8 1.16
usr.sbin/dhcpd/dhcpd.c 1.35
usr.sbin/dhcpd/dhcpd.h 1.36
usr.sbin/dhcpd/dispatch.c 1.23
usr.sbin/dhcpd/errwarn.c 1.8
usr.sbin/dhcpd/memory.c 1.15
usr.sbin/dhcpd/sync.c 1.1
usr.sbin/dhcpd/sync.h 1.1
Add synchronisation support for dhcpd - this allows for two dhcpd's with the same configuration to be run on the same net and they will keep their lease files/state in synch, and therefore allowing you to run redundant dhcpd's. Synchronization code stolen from spamd, uses an hmac key in /var/db/dhcpd.key if it exists. ok krw@ deraadt@
00:36 krw usr.sbin/dhcpd/options.c 1.21
Redo/clarify the logic for storing options in the various buffers.
While there, bail out quickly if no options can be stored, and avoid overflow buffers if building a bootp reply.
Henning looked and didn't get upset. millert@ tested it for a few days and liked the look of it. canacar@ glanced at it.
22:44 dlg usr.sbin/dhcpd/tables.c 1.7
option 144 is commonly used for tftp-config-file.
ok henning@ krw@
00:17 dlg usr.sbin/dhcpd/tables.c 1.6
option 252 is generally used to specify an autoproxy-script on a subnet.
ok krw@ henning@
20:14 tag OPENBSD_4_3_BASE added
20:14 krw usr.sbin/dhcpd/dhcpd.h 1.35
usr.sbin/dhcpd/options.c 1.20
Call store_options() with correct cutoff values, i.e. ones not 7 bytes too large. Fixes a problem where a nicely crafted packet could crash dhcpd. Nuke a superfluous declaration of store_options() while here.
Problem found and fix tested by Peter Hessler.
ok beck@ millert@ henning@
13:38 sobrado usr.sbin/dhcpd/dhcpd.c 1.34
add missing space between argument names and ellipsis
ok jmc@
21:54 jmc usr.sbin/dhcpd/dhcpd.conf.5 1.7
for "fixed-address", note that no lease is generated; after some discussion with krw, who hasn;t ok'd this diff, but we can change it if he doesn;t like it;
started by mail from Max Hayden Chiz
21:52 jmc usr.sbin/dhcpd/pfutils.c 1.9
remove double word in comment;
16:51 krw usr.sbin/dhcpd/dhcpd.h 1.34
usr.sbin/dhcpd/options.c 1.19
usr.sbin/dhcpd/tables.c 1.5
More tweaking of option processing, this time around the creation of the priority list. Add create_priority_list() and use it to consistantly merge mandatory, supplied and default option priority lists into a reliable and complete list of options sorted by priority. No intended functional change other than ensuring all options available are returned.
"looks good" henning@ "OK, fair enough" millert@
15:19 krw usr.sbin/dhcpd/tables.c 1.4
Remove duplicate DHO_HOST_NAME entry and add missing DHO_DHCP_USER_CLASS_ID entry to dhcp_option_default_priority_list[]. Reformat list of numbers at the end of dhcp_option_default_priority_list[] so it is easy to see which options are defined. No functional change.
14:47 krw usr.sbin/dhcpd/options.c 1.18
Rework option storing so the code is readable, and eliminate odd behaviour on several edge conditions.
Feedback, suggestion & "I like the approach" millert@ "excellent" henning@.
13:12 krw usr.sbin/dhcpd/options.c 1.17
Take even more care to ensure the max message size is at least as large as the minimum IP MTU.
ok canacar@ henning@ millert@
01:08 krw usr.sbin/dhcpd/options.c 1.16
Last bit of (planned) tidy up in cons_options(). Join some lines, delete some blank lines, add some other blank lines, move expressions so calculations done only once. Eliminate extraneous ++'s.
No functional change.
00:39 krw usr.sbin/dhcpd/options.c 1.15
Tidy up, make usual case exit faster, eliminate variable. No functional change.
ok beck@
15:52 krw usr.sbin/dhcpd/options.c 1.14
Make sure bufix is updated after copying options into the first overflow buffer. Actually use the second overflow buffer now that bufix is correct and the test for remaining options will work correctly.
ok beck@
15:43 krw usr.sbin/dhcpd/options.c 1.13
Be a bit more paranoid and initialize all valid options buffers with DHO_PAD (a.k.a. 0). Eliminate manual DHO_PAD'ing after DHO_END is put into the buffer.
ok beck@
15:34 krw usr.sbin/dhcpd/options.c 1.12
Fix obvious typos and write DHO_PAD and DHO_END into correct options overflow buffer. Spotted by canacar@ and others.
ok beck@
15:25 krw usr.sbin/dhcpd/options.c 1.11
Correct the value returned by cons_options in the case where overload buffers are used. It should reflect the end of the main options buffer rather than the start of the options copied into it.
ok beck@
15:16 krw usr.sbin/dhcpd/options.c 1.10
Ensure that main_buffer_size is set to a value less than or equal to the size of the outgoing packet's options field. Spotted by canacar@.
ok beck@
06:10 ckuethe usr.sbin/dhcpd/options.c
merge fix from current, prompted by deraadt. original commit message: "Minimum IP MTU" means what it says. Ensure that packets returned by dhcpd are the minimum size or larger no matter what the client thinks the minimum allowable size is. Found by Nahuel Riva and Gera Richarte. Fix by millert@.
16:44 ckuethe usr.sbin/dhcpd/options.c
merge fix from current, prompted by deraadt. original commit message: "Minimum IP MTU" means what it says. Ensure that packets returned by dhcpd are the minimum size or larger no matter what the client thinks the minimum allowable size is. Found by Nahuel Riva and Gera Richarte. Fix by millert@.
03:17 krw usr.sbin/dhcpd/options.c 1.9
"Minimum IP MTU" means what it says. Ensure that packets returned by dhcpd are the minimum size or larger no matter what the client thinks the minimum allowable size is. Found by Nahuel Riva and Gera Richarte. Fix by millert@.
15:45 ckuethe usr.sbin/dhcpd/pfutils.c 1.8
Allow the various pf table actions to operate independently. For example, "-L leased" wouldn't work without "-A abandoned". testing help from merdely "i like" deraadt
15:31 tag OPENBSD_4_2_BASE added
15:31 stevesk usr.sbin/dhcpd/dhcpd.c 1.33
use 1 vs. -1 for true; ok henning@ krw@
19:20 jmc usr.sbin/dhcpd/dhcp-options.5 1.9
usr.sbin/dhcpd/dhcpd.8 1.15
usr.sbin/dhcpd/dhcpd.conf.5 1.6
usr.sbin/dhcpd/dhcpd.leases.5 1.6
convert to new .Dd format;
06:22 tedu usr.sbin/dhcpd/pfutils.c 1.7
use the correct fd for poll. we're waiting on the pipe, not pf ok ckuethe deraadt
18:26 tag OPENBSD_4_1_BASE added
18:26 stevesk usr.sbin/dhcpd/dhcp.h 1.5
spaces and comment to sync to dhclient dhcp.h; no binary change
11:37 henning usr.sbin/dhcpd/errwarn.c 1.7
pull in spaces array overflow fixes from dhclient the code here is slightly different, but also has the overfow in both cases
00:49 stevesk usr.sbin/dhcpd/parse.c 1.11
don't leak memory, from dhclient; ok krw@
07:02 henning usr.sbin/dhcpd/dhcpd.h 1.33
another dead extern; Mark Lumsden <mark@cyodesigns.com>
21:19 henning usr.sbin/dhcpd/dhcpd.h 1.32
unused extern decl From: Mark Lumsden <mark@cyodesigns.com>
18:27 deraadt usr.sbin/dhcpd/dhcpd.c 1.32
-q flag is unused (old shared code from dhclient); spotted by mark@cyodesigns ok krw
13:32 jmc usr.sbin/dhcpd/dhcpd.8 1.14
usr.sbin/dhcpd/dhcpd.c 1.31
no code for -p, so remove from man page and usage(); confirmed by ckuethe; spotted by Mark Lumsden
21:12 stevesk usr.sbin/dhcpd/dhcpd.h 1.31
17:58 stevesk usr.sbin/dhcpd/dhcpd.h 1.30
remove some dangling function prototypes
22:39 krw usr.sbin/dhcpd/dhcp.h 1.4
Don't count ethernet as overhead for UDP packet constuction. Gives 14 more bytes of option space! A change ISC made a long time ago.
ok stevesk@ (DHCP) canacar@ (bpf)
01:51 stevesk usr.sbin/dhcpd/dhcp.h 1.3
remove unused #define DHCP_MIN_LEN
19:12 stevesk usr.sbin/dhcpd/dhcpd.h 1.29
<sys/un.h> not needed
19:05 stevesk usr.sbin/dhcpd/dhctoken.h 1.5
align, no binary change
18:03 stevesk usr.sbin/dhcpd/conflex.c 1.9
usr.sbin/dhcpd/confpars.c 1.16
usr.sbin/dhcpd/dhcpd.h 1.28
usr.sbin/dhcpd/dhctoken.h 1.4
remove one-lease-per-client parameter which was never implemented (it doesn't do anything and is not documented); ok henning@
16:03 stevesk usr.sbin/dhcpd/dhcp.c 1.25
small KNF
14:09 stevesk usr.sbin/dhcpd/options.c 1.8
typo in comment
19:38 stevesk usr.sbin/dhcpd/dispatch.c 1.22
usr.sbin/dhcpd/options.c 1.7
remove unused #defines; no binary change
19:32 stevesk usr.sbin/dhcpd/dhcpd.h 1.27
<signal.h> not needed
23:40 stevesk usr.sbin/dhcpd/dhcpd.h 1.26
21:35 stevesk usr.sbin/dhcpd/parse.c 1.10
sync dhclient and dhcpd parse.c areas where we can. mainly formatting, whitespace; ok henning@
19:10 stevesk usr.sbin/dhcpd/dhcpd.c 1.30
usr.sbin/dhcpd/dhcpd.h 1.25
small header cleanup: remove uneeded header use <foo.h> not "foo.h" for system include
no binary change; ok henning@
18:07 stevesk usr.sbin/dhcpd/parse.c 1.9
fix some warning messages and comments in parse_date(); ok henning@
16:26 stevesk usr.sbin/dhcpd/dhcpd.h 1.24
remove unused #defines; remove duplicate #defines; remove DEBUG; remove useless comment; no need to #ifdef protect.
no binary change; ok henning@
00:10 stevesk usr.sbin/dhcpd/dhcpd.h 1.23
re-order includes and eliminate duplicates, no binary change; ok henning@
19:14 stevesk usr.sbin/dhcpd/dhcpd.h 1.22
KNF (no space before '['); ok henning@
15:49 stevesk usr.sbin/dhcpd/dhcp-options.5 1.8
remove another irrelevant reference; ok jmc@
16:46 jmc usr.sbin/dhcpd/dhcp-options.5 1.7
remove some irrelevant references; spotted by stevesk ok henning stevesk
19:45 deraadt usr.sbin/dhcpd/pfutils.c 1.6
01:51 brad usr.sbin/dhcpd/memory.c
MFC: Fix by cloder@
Fix a reliability issue in dhcpd where a DHCPDISCOVER packet with a 32-byte client identifier would cause dhcpd to mistakenly exit. From Debian bug 380273, affecting ISC dhcpd 2.x, upon which our dhcpd is based.
ok cloder@
22:23 tag OPENBSD_4_0_BASE added
22:23 cloder usr.sbin/dhcpd/memory.c 1.14
Fix a reliability issue in dhcpd where a DHCPDISCOVER packet with a 32-byte client identifier would cause dhcpd to mistakenly exit. From Debian bug 380273, affecting ISC dhcpd 2.x, upon which our dhcpd is based.
OK beck@
11:05 stevesk usr.sbin/dhcpd/dhcpd.8 1.13
typo in example config; ok henning@
20:19 jmc usr.sbin/dhcpd/dhcpd.8 1.12
usr.sbin/dhcpd/dhcpd.c 1.29
sort options;
14:58 ckuethe usr.sbin/dhcpd/dhcpd.8 1.11
usr.sbin/dhcpd/dhcpd.c 1.28
usr.sbin/dhcpd/dhcpd.h 1.21
usr.sbin/dhcpd/memory.c 1.13
usr.sbin/dhcpd/pfutils.c 1.5
This diff allows dhcpd to put active leases into a pf table. Dhcpd will then periodically - based on the length of the shortest lease time - walk across all leases searching for expired leases which are then removed from the pf table.
ok henning
14:49 ckuethe usr.sbin/dhcpd/dhcp.c 1.24
usr.sbin/dhcpd/dhcpd.h 1.20
usr.sbin/dhcpd/memory.c 1.12
usr.sbin/dhcpd/pfutils.c 1.4
Move the transmission of privsep messages into its own function. Wherever we might have conditionally sent a message, we now just call the pfmsg() function, and let it figure out whether the message should be sent or not.
ok henning
14:44 ckuethe usr.sbin/dhcpd/pfutils.c 1.3
Avoid changing pf tables when table name is NULL ok henning
08:47 jmc usr.sbin/dhcpd/confpars.c 1.15
typo; from sstull ok ckuethe
06:06 ckuethe usr.sbin/dhcpd/dhcpd.c 1.27
Sort options in usage. From jmc. ok henning@
14:40 ckuethe usr.sbin/dhcpd/pfutils.c 1.2
Missing $OpenBSD$ tag. Spotted by Masao Uebayashi. ok henning@
09:05 jmc usr.sbin/dhcpd/dhcpd.8 1.10
- tidy up SYNOPSIS - sort options - +.Xr pf 4 ,
02:43 ckuethe usr.sbin/dhcpd/Makefile 1.3
usr.sbin/dhcpd/dhcp.c 1.23
usr.sbin/dhcpd/dhcpd.8 1.9
usr.sbin/dhcpd/dhcpd.c 1.26
usr.sbin/dhcpd/dhcpd.h 1.19
usr.sbin/dhcpd/memory.c 1.11
usr.sbin/dhcpd/pfutils.c 1.1
This diff makes dhcpd able to manipulate pf tables on certain lease events.
dhcpd is now able to place abandoned addresses into a table (to offer some protection against machines camping on an address) and remove them from the table if they are properly leased.
When dhcpd assigns an IP to a new hardware address, it can remove that address from a table. This is for use with the overload table in pf; newly arrived machines will not be punished for the actions of a machine that went away.
beck@ and krw@ liked previous versions of this, henning@ final ok
23:43 ckuethe usr.sbin/dhcpd/dhcpd.h 1.18
usr.sbin/dhcpd/dispatch.c 1.21
This patch renames dhcpd's "struct timeout" to "struct dhcpd_timeout" so as not to conflict with "struct timeout" from <sys/timeout.h>. ok henning@
19:27 stevesk usr.sbin/dhcpd/dhcpd.conf.5 1.5
repair some broken indentation in an example; ok jmc@
19:52 krw usr.sbin/dhcpd/dispatch.c 1.20
Don't exit just because an interface has no subnet configured in dhcpd.conf. Just don't listen on that interface.
Make warning messages textually consistant.
tested & ok beck@
04:01 krw usr.sbin/dhcpd/dispatch.c 1.19
When an interface is ignored because it has no IP address, say so. Don't just say 'not found". And always complain, not just when specific interfaces were requested.
requested by and ok uwe@
01:19 krw usr.sbin/dhcpd/dhcpd.c 1.25
usr.sbin/dhcpd/dhcpd.h 1.17
usr.sbin/dhcpd/dispatch.c 1.18
If a list of interfaces is supplied via the command line or dhcpd.interfaces then
a) don't bother looking up information on interfaces that were not requested;
b) don't exit if a requested interface is not found, just issue a warning message;
c) exit if none of the interfaces were found.
The command line for dhcpd shown in ps will continue to show requested but ignored interfaces.
As usual with dhc* code, whack a bunch of unused states, constants, flags, etc. Since we only invoke discover_interfaces() with DISCOVER_SERVER, there is no need to keep track of other possibilities.
19:50 deraadt usr.sbin/dhcpd/conflex.c 1.8
list must be sorted
19:18 deraadt usr.sbin/dhcpd/conflex.c 1.7
usr.sbin/dhcpd/confpars.c 1.14
usr.sbin/dhcpd/dhctoken.h 1.3
usr.sbin/dhcpd/parse.c 1.8
cleanup keyword lookup for the lexer, and remove keywords not valid in either dhclient or dhcpd context; tested by many
15:44 claudio usr.sbin/dhcpd/dhcp.c 1.22
usr.sbin/dhcpd/dispatch.c 1.17
KNF. No binary change.
19:57 otto usr.sbin/dhcpd/bootp.c 1.13
usr.sbin/dhcpd/confpars.c 1.13
usr.sbin/dhcpd/dhcp.c 1.21
usr.sbin/dhcpd/tree.c 1.11
tiny bit of delinting; ok krw@
09:59 tag OPENBSD_3_9_BASE added
09:59 jmc usr.sbin/dhcpd/dhcp-options.5 1.6
NTP is described by RFC 1305, not 1035; from michal f. hanula (freebsd docs/92629)
19:27 jmc usr.sbin/dhcpd/dhcpd.conf.5 1.4
correction from tamas tevesz; ok ian
16:24 krw usr.sbin/dhcpd/conflex.c 1.6
Missing 'break;' found by lint. 'blass' is not the same as 'class'!
ok moritz@ otto@
21:33 beck usr.sbin/dhcpd/dhcp.c 1.20
fix problem of dhcp server looping with "already acking lease" when busy with short lease times. Fix by and discussed with millert over a year ago, run at u of a for over a year, but never committed. ok millert@ cloder@
20:25 deraadt usr.sbin/dhcpd/print.c 1.10
pretty up print_hw_addr(), and even fix a teeny buffer overflow; ok otto
20:34 jaredy usr.sbin/dhcpd/dhcp-options.5 1.5
usr.sbin/dhcpd/dhcpd.8 1.8
usr.sbin/dhcpd/dhcpd.conf.5 1.3
usr.sbin/dhcpd/dhcpd.leases.5 1.5
deploy .An -nosplit; ok jmc
17:26 tag OPENBSD_3_8_BASE added
17:26 krw usr.sbin/dhcpd/bpf.c 1.6
Fix erroneous use of '=' instead of '+' that caused infinite loops when skipping packets. Use BPF_WORDALIGN() to properly skip packets. From Brooks Davis at FreeBSD.
ok deraadt@ henning@
19:14 krw usr.sbin/dhcpd/conflex.c 1.5
Fix buffer overflows in dhcpd and dhclient. Closes PR#4306.
ok henning@
22:54 henning usr.sbin/dhcpd/dhcpd.c 1.24
02:29 djm usr.sbin/dhcpd/dhcpd.c 1.23
more setres[ug]id; ok deraadt@
16:39 moritz usr.sbin/dhcpd/errwarn.c 1.6
usr.sbin/dhcpd/print.c 1.9
snprintf() return value handling. ok cloder@ henning@
19:59 deraadt usr.sbin/dhcpd/errwarn.c 1.5
use STDERR_FILENO; ok cloder
18:59 deraadt usr.sbin/dhcpd/errwarn.c 1.4
use writev() here too; henning ok
18:50 fgsch usr.sbin/dhcpd/errwarn.c 1.3
when -d is used, log to stderr, not via syslog(3); fixed pr/4171. ok henning@
15:55 tag OPENBSD_3_7_BASE added
15:55 jmc usr.sbin/dhcpd/dhcp-options.5 1.4
oops - 2 copies of this file... move the .Bl after .Ss;
22:21 claudio usr.sbin/dhcpd/dhcp.c 1.19
Be a bit more paranoid about leases that are currently acked. There is a small window where it is possible that a lease is acked and simultaniously removed and so the state is not removed. This may be a cause for the "already acking" issue. OK millert@
21:23 claudio usr.sbin/dhcpd/bootp.c 1.12
usr.sbin/dhcpd/dhcp.c 1.18
Simply use the ethernet source address of the request as new ethernet destination instead of the one included in the dhcp packet. Especially because there are to many cases where the supplied address is wrong. This hopefully solves all problems with gateways involved, like the one reported by Dylan Martin. OK krw@ henning@ millert@
18:27 millert usr.sbin/dhcpd/dispatch.c 1.16
Don't malloc fds each time, just realloc() as needed. There's no need to clear revents -- poll() does that for us. Move setting of cur_time to the top of the loop for better accuracy. When poll returns 0, don't check revents since we know none were set.
16:29 millert usr.sbin/dhcpd/dhcp.c 1.17
Fix memory leak when supersede_lease() fails and it is a DHCPACK or a dynamic BOOTREPLY offer. OK claudio@
17:18 claudio usr.sbin/dhcpd/dhcp.c 1.16
Bah, unbreak. from not form. Noticed by Dan Harnett.
13:51 claudio usr.sbin/dhcpd/dhcp.c 1.15
Set correct source address for relayed packets. This affects only setups that use 'next-server' config option. From Hans Kremers. OK henning@
10:43 canacar usr.sbin/dhcpd/dhcpd.8 1.7
usr.sbin/dhcpd/dhcpd.c 1.22
usr.sbin/dhcpd/dhcpd.h 1.16
usr.sbin/dhcpd/dispatch.c 1.15
change the undocumented -t flag to -n used for configuration testing and document it. cleanup some unused/unneeded variables while there. idea & ok henning@
04:07 david usr.sbin/dhcpd/dispatch.c 1.14
usr.sbin/dhcpd/memory.c 1.10
usr.sbin/dhcpd/options.c 1.6
spelling fixes; ok jmc@ henning@
21:27 claudio usr.sbin/dhcpd/inet.c 1.5
Use inet_ntop() instead of inet_ntoa() in piaddr. This solves a problem where inet_ntoa() was called twice per log message -- once here and once directly. This is a workaround acctually no static buffer should be used. OK deraadt@
18:35 deraadt usr.sbin/dhcpd/alloc.c 1.4
usr.sbin/dhcpd/bootp.c 1.11
usr.sbin/dhcpd/bpf.c 1.5
usr.sbin/dhcpd/conflex.c 1.4
usr.sbin/dhcpd/confpars.c 1.12
usr.sbin/dhcpd/db.c 1.10
usr.sbin/dhcpd/dhcp.c 1.14
usr.sbin/dhcpd/dhcpd.c 1.21
usr.sbin/dhcpd/dhcpd.h 1.15
usr.sbin/dhcpd/dispatch.c 1.13
usr.sbin/dhcpd/errwarn.c 1.2
usr.sbin/dhcpd/hash.c 1.3
usr.sbin/dhcpd/icmp.c 1.9
usr.sbin/dhcpd/memory.c 1.9
usr.sbin/dhcpd/options.c 1.5
usr.sbin/dhcpd/parse.c 1.7
usr.sbin/dhcpd/tree.c 1.10
usr.sbin/dhcpd/tree.h 1.5
avoid aliasing with libc functions; ok henning
09:35 claudio usr.sbin/dhcpd/bootp.c 1.10
usr.sbin/dhcpd/dhcp.c 1.13
usr.sbin/dhcpd/dhcpd.h 1.14
usr.sbin/dhcpd/dispatch.c 1.12
Remove the not initialized fallback_interface code and use the normal bpf interface for that. Also store the hardware (ethernet) address in the state so that relayed dhcp request are sent to the correct destination. OK henning@ requested by deraadt@ tested otto@
22:12 deraadt usr.sbin/dhcpd/dispatch.c 1.11
size_t vs ssize_t confusion
18:15 henning usr.sbin/dhcpd/confpars.c 1.11
minor KNF, Moritz Jodeit <moritz@jodeit.org>
20:51 tag OPENBSD_3_6_BASE added
20:51 millert usr.sbin/dhcpd/confpars.c 1.10
usr.sbin/dhcpd/dhcpd.c 1.20
Avoid following a NULL pointer if a hostname lookup fails and remove an extraneous "exiting" when there is a config file error. OK henning@ and mcbride@
19:38 pvalchev usr.sbin/dhcpd/dhcpd.8 1.6
update bootp example "filename" location to reflect tftp default of chrooting to /tftpboot (thus "filename foo" searches there); ok henning
11:58 henning usr.sbin/dhcpd/db.c 1.9
don't wipe lease file on startup, found & solution tested nick@
16:22 deraadt usr.sbin/dhcpd/db.c 1.8
16:27 henning usr.sbin/dhcpd/dhcp-options.5 1.3
fix the "option dhcp-client-identifier" hex example From: Marco Munari <mar@i.am> in PR3824
17:41 canacar usr.sbin/dhcpd/dispatch.c 1.10
handle interface removals gracefully. reported by Oliver J. Morais ok henning@, tedu@
06:22 henning usr.sbin/dhcpd/dhcp.c 1.12
typo; From: Andrey Matveev <andrushock@korovino.net>
10:20 henning usr.sbin/dhcpd/dhcpd.c 1.19
like always I missed tzset(); Ben Lovett <ben@tilderoot.com>
04:08 deraadt usr.sbin/dhcpd/bootp.c 1.9
usr.sbin/dhcpd/memory.c 1.8
06:12 henning usr.sbin/dhcpd/tree.c 1.9
remove hostname lookup stuff, done at parse time now, ok theo
06:11 henning usr.sbin/dhcpd/confpars.c 1.9
resolve hostnames at parse time, solves PR3771, ok theo
22:05 deraadt usr.sbin/dhcpd/confpars.c 1.8
21:25 deraadt usr.sbin/dhcpd/convert.c 1.4
usr.sbin/dhcpd/dhcp.c 1.11
usr.sbin/dhcpd/dhcpd.h 1.13
usr.sbin/dhcpd/options.c 1.4
usr.sbin/dhcpd/print.c 1.8
remove DEBUG_PACKET stuff; henning ok
20:28 deraadt usr.sbin/dhcpd/alloc.c 1.3
usr.sbin/dhcpd/bootp.c 1.8
usr.sbin/dhcpd/bpf.c 1.4
usr.sbin/dhcpd/convert.c 1.3
usr.sbin/dhcpd/dhcp.c 1.10
usr.sbin/dhcpd/dhcpd.c 1.18
usr.sbin/dhcpd/dhcpd.h 1.12
usr.sbin/dhcpd/dispatch.c 1.9
usr.sbin/dhcpd/inet.c 1.4
usr.sbin/dhcpd/memory.c 1.7
usr.sbin/dhcpd/options.c 1.3
usr.sbin/dhcpd/parse.c 1.6
usr.sbin/dhcpd/print.c 1.7
remove things not used, spotted by lint mostly; ok henning
15:22 henning usr.sbin/dhcpd/dhcpd.h 1.11
usr.sbin/dhcpd/icmp.c 1.8
instead of using some lower 16 bits of some address on the stack that even requires knowledge about wether the machine is 32 or 64 bit, use getpid() for the icmp id. that is not optimal, but matches what ping does and the way to go for now.
22:44 henning usr.sbin/dhcpd/icmp.c 1.7
cleaning; Ryan ok
09:11 canacar usr.sbin/dhcpd/bootp.c 1.7
usr.sbin/dhcpd/bpf.c 1.3
usr.sbin/dhcpd/dhcp.c 1.9
usr.sbin/dhcpd/dhcpd.c 1.17
usr.sbin/dhcpd/dhcpd.h 1.10
usr.sbin/dhcpd/packet.c 1.3
filter writes and lock bpf descriptor, ok henning@
08:00 jmc usr.sbin/dhcpd/dhcpd.leases.5 1.4
missing comma;
07:59 jmc usr.sbin/dhcpd/dhcp-options.5 1.2
sync AUTHORS w/ other dhcpd pages; ok henning@
01:44 henning usr.sbin/dhcpd/dhcpd.c 1.16
fix the error message in case the _dhcp user does not exist
23:01 henning usr.sbin/dhcpd/Makefile 1.2
usr.sbin/dhcpd/dhcp-options.5 1.1
add back manpage that was forgotten during the switch, catched by and ok theo
05:35 henning usr.sbin/dhcpd/confpars.c 1.7
usr.sbin/dhcpd/dhcp.c 1.8
usr.sbin/dhcpd/dhcpd.h 1.9
usr.sbin/dhcpd/dispatch.c 1.8
usr.sbin/dhcpd/icmp.c 1.6
usr.sbin/dhcpd/memory.c 1.6
usr.sbin/dhcpd/print.c 1.6
usr.sbin/dhcpd/tree.c 1.8
03:58 henning usr.sbin/dhcpd/dhcpd.8 1.5
there are lies, damn lies, and isc dhcpd manpages
03:46 henning usr.sbin/dhcpd/dhcpd.8 1.4
usr.sbin/dhcpd/dhcpd.leases.5 1.3
remove lies about the leases file and its handling
00:27 henning usr.sbin/dhcpd/dhcpd.8 1.3
usr.sbin/dhcpd/dhcpd.c 1.15
don't allow the port to be changed here either
17:05 tom usr.sbin/dhcpd/dhcp.c 1.7
Catch negative lease times. From openbsd@nerd-marrow.com in PR 2888, which this closes (though the PR was for usr.sbin/dhcpd/server/).
ok henning@
01:32 deraadt usr.sbin/dhcpd/bootp.c 1.6
usr.sbin/dhcpd/dhcp.c 1.6
01:19 henning usr.sbin/dhcpd/bootp.c 1.5
usr.sbin/dhcpd/confpars.c 1.6
usr.sbin/dhcpd/db.c 1.7
usr.sbin/dhcpd/dispatch.c 1.7
more KNF
00:59 deraadt usr.sbin/dhcpd/confpars.c 1.5
more knf
00:43 deraadt usr.sbin/dhcpd/bootp.c 1.4
usr.sbin/dhcpd/confpars.c 1.4
usr.sbin/dhcpd/db.c 1.6
usr.sbin/dhcpd/dhcp.c 1.5
usr.sbin/dhcpd/dhcpd.c 1.14
usr.sbin/dhcpd/dhcpd.h 1.8
usr.sbin/dhcpd/dispatch.c 1.6
usr.sbin/dhcpd/icmp.c 1.5
usr.sbin/dhcpd/memory.c 1.5
usr.sbin/dhcpd/parse.c 1.5
usr.sbin/dhcpd/print.c 1.5
usr.sbin/dhcpd/tables.c 1.3
usr.sbin/dhcpd/tree.c 1.7
various knf; henning ok
00:30 henning usr.sbin/dhcpd/dhcpd.c 1.13
dhcpd may be invoked without any interface given
04:30 deraadt usr.sbin/dhcpd/dhcp.c 1.4
usr.sbin/dhcpd/dhcpd.c 1.12
usr.sbin/dhcpd/dispatch.c 1.5
usr.sbin/dhcpd/inet.c 1.3
usr.sbin/dhcpd/memory.c 1.4
usr.sbin/dhcpd/print.c 1.4
usr.sbin/dhcpd/tree.c 1.6
a bunch of knf, ok henning
23:20 henning usr.sbin/dhcpd/dhcpd.c 1.11
chroot and drop privileges after startup
23:20 henning usr.sbin/dhcpd/db.c 1.5
do not close and re-open the leases file all the time, instead open it once and rewind as neccessary
23:17 henning usr.sbin/dhcpd/bpf.c 1.2
dhcpd actually does not listen on port 68 ...
22:22 hshoexer usr.sbin/dhcpd/parse.c 1.4
usr.sbin/dhcpd/print.c 1.3
knf + ansi
ok henning@
21:57 henning usr.sbin/dhcpd/bootp.c 1.3
usr.sbin/dhcpd/db.c 1.4
cleaning; from pedro
21:47 hshoexer usr.sbin/dhcpd/tree.c 1.5
usr.sbin/dhcpd/tree.h 1.4
knf + ansi
ok henning@
08:34 jmc usr.sbin/dhcpd/dhcpd.8 1.2
usr.sbin/dhcpd/dhcpd.c 1.10
usr.sbin/dhcpd/dhcpd.conf.5 1.2
usr.sbin/dhcpd/dhcpd.leases.5 1.2
- trim/update AUTHORS - standard options list and correct SYNOPSIS for dhcpd(8) - sync usage()
ok henning@
04:45 henning usr.sbin/dhcpd/version.h 1.2
useless too
04:44 deraadt usr.sbin/dhcpd/icmp.c 1.4
04:42 henning usr.sbin/dhcpd/dhcpd.cat8 1.2
usr.sbin/dhcpd/dhcpd.conf.cat5 1.2
usr.sbin/dhcpd/dhcpd.leases.cat5 1.2
king bula sez those are bula
04:34 deraadt usr.sbin/dhcpd/bootp.c 1.2
usr.sbin/dhcpd/confpars.c 1.3
usr.sbin/dhcpd/db.c 1.3
usr.sbin/dhcpd/dhcp.c 1.3
usr.sbin/dhcpd/dhcpd.c 1.9
usr.sbin/dhcpd/dhcpd.h 1.7
usr.sbin/dhcpd/dispatch.c 1.4
usr.sbin/dhcpd/icmp.c 1.3
usr.sbin/dhcpd/memory.c 1.3
usr.sbin/dhcpd/print.c 1.2
usr.sbin/dhcpd/tree.c 1.4
04:21 henning usr.sbin/dhcpd/dhcpd.c 1.8
KNF, ansi and such
04:13 henning usr.sbin/dhcpd/dhcpd.c 1.7
03:59 henning usr.sbin/dhcpd/dhcpd.c 1.6
less pathetic usage(), and I felt free to remove the helpfull /* print usage message */
02:18 henning usr.sbin/dhcpd/dhcpd.c 1.5
remove pidfile gunk, use daemon, and get rid of some debugging crap
02:13 henning usr.sbin/dhcpd/dhcpd.c 1.4
don't print half a terminal worth of vixie advertising at startup and in usage
01:27 henning usr.sbin/dhcpd/convert.c 1.2
usr.sbin/dhcpd/inet.c 1.2
usr.sbin/dhcpd/options.c 1.2
usr.sbin/dhcpd/parse.c 1.3
usr.sbin/dhcpd/tables.c 1.2
the ones from dhclient do, and they're already KNF'd and annsified...
01:09 henning usr.sbin/dhcpd/dhcp.h 1.2
usr.sbin/dhcpd/dhcpd.h 1.6
usr.sbin/dhcpd/dhctoken.h 1.2
usr.sbin/dhcpd/hash.h 1.2
usr.sbin/dhcpd/inet.h 1.2
usr.sbin/dhcpd/tree.h 1.3
fold in 10liners and clean up other .hs a bit
00:56 henning usr.sbin/dhcpd/cdefs.h 1.2
usr.sbin/dhcpd/conflex.c 1.3
usr.sbin/dhcpd/dhcpd.c 1.3
usr.sbin/dhcpd/dhcpd.h 1.5
usr.sbin/dhcpd/dispatch.c 1.3
usr.sbin/dhcpd/hash.c 1.2
usr.sbin/dhcpd/icmp.c 1.2
usr.sbin/dhcpd/packet.c 1.2
usr.sbin/dhcpd/sysconf.h 1.2
usr.sbin/dhcpd/tree.c 1.3
more crap bites the dust
00:24 henning usr.sbin/dhcpd/dhcpd.h 1.4
usr.sbin/dhcpd/osdep.h 1.4
bye bye
00:20 henning usr.sbin/dhcpd/alloc.c 1.2
cheat to KNF and ansi this: take the one from dhclient and add back the few missing functions
00:06 henning usr.sbin/dhcpd/dhcpd.h 1.3
dhcpd may know about a thousand strange things to get packets onto the wire, but we do not care for them, really
00:01 henning usr.sbin/dhcpd/osdep.h 1.3
we want bpf only
23:59 henning usr.sbin/dhcpd/osdep.h 1.2
usr.sbin/dhcpd/site.h 1.2
sure a good idea to include 100 lines of comments Just Because...
23:57 henning usr.sbin/dhcpd/conflex.c 1.2
usr.sbin/dhcpd/confpars.c 1.2
usr.sbin/dhcpd/db.c 1.2
usr.sbin/dhcpd/dhcp.c 1.2
usr.sbin/dhcpd/dhcpd.c 1.2
usr.sbin/dhcpd/dhcpd.h 1.2
usr.sbin/dhcpd/dispatch.c 1.2
usr.sbin/dhcpd/memory.c 1.2
usr.sbin/dhcpd/parse.c 1.2
usr.sbin/dhcpd/tree.c 1.2
usr.sbin/dhcpd/tree.h 1.2
time_t and kill a few dumb defines
23:41 henning usr.sbin/dhcpd/Makefile 1.1
usr.sbin/dhcpd/alloc.c 1.1
usr.sbin/dhcpd/bootp.c 1.1
usr.sbin/dhcpd/bpf.c 1.1
usr.sbin/dhcpd/cdefs.h 1.1
usr.sbin/dhcpd/conflex.c 1.1
usr.sbin/dhcpd/confpars.c 1.1
usr.sbin/dhcpd/convert.c 1.1
usr.sbin/dhcpd/db.c 1.1
usr.sbin/dhcpd/dhcp.c 1.1
usr.sbin/dhcpd/dhcp.h 1.1
usr.sbin/dhcpd/dhcpd.8 1.1
usr.sbin/dhcpd/dhcpd.c 1.1
usr.sbin/dhcpd/dhcpd.cat8 1.1
usr.sbin/dhcpd/dhcpd.conf 1.1
usr.sbin/dhcpd/dhcpd.conf.5 1.1
usr.sbin/dhcpd/dhcpd.conf.cat5 1.1
usr.sbin/dhcpd/dhcpd.h 1.1
usr.sbin/dhcpd/dhcpd.leases.5 1.1
usr.sbin/dhcpd/dhcpd.leases.cat5 1.1
usr.sbin/dhcpd/dhctoken.h 1.1
usr.sbin/dhcpd/dispatch.c 1.1
usr.sbin/dhcpd/errwarn.c 1.1
usr.sbin/dhcpd/hash.c 1.1
usr.sbin/dhcpd/hash.h 1.1
usr.sbin/dhcpd/icmp.c 1.1
usr.sbin/dhcpd/inet.c 1.1
usr.sbin/dhcpd/inet.h 1.1
usr.sbin/dhcpd/memory.c 1.1
usr.sbin/dhcpd/options.c 1.1
usr.sbin/dhcpd/osdep.h 1.1
usr.sbin/dhcpd/packet.c 1.1
usr.sbin/dhcpd/parse.c 1.1
usr.sbin/dhcpd/print.c 1.1
usr.sbin/dhcpd/site.h 1.1
usr.sbin/dhcpd/sysconf.h 1.1
usr.sbin/dhcpd/tables.c 1.1
usr.sbin/dhcpd/tree.c 1.1
usr.sbin/dhcpd/tree.h 1.1
usr.sbin/dhcpd/version.h 1.1
may the whacking begin

This page was created on Fri Feb 10 10:55:13 2017 using cl2html written by Simon Josefsson.